LCS2016_I09 < P1076

P1076 Web>VHDL2017>LCS2016_I09 (2017-04-02, PatrickLehmann) (raw view)EditAttach
---+ Language Change Specification for Repair LRM Example 5.6.3 Proposal

<table border="1" cellpadding="0" cellspacing="0" id="table1" rules="all"> <tbody> <tr> <td bgcolor="#ffffff" valign="top"> *LCS Number:* </td> <td bgcolor="#ffffff" valign="top">LCS-2016-I09</td> </tr> <tr> <td bgcolor="#edf4f9" valign="top"> *Version:* </td> <td bgcolor="#edf4f9" valign="top">1</td> </tr> <tr> <td bgcolor="#ffffff" valign="top"> *Date:* </td> <td bgcolor="#ffffff" valign="top">Nov-30-2016</td> </tr> <tr> <td bgcolor="#edf4f9" valign="top"> *Status:* </td> <td bgcolor="#edf4f9" valign="top"> </td> </tr> <tr> <td bgcolor="#ffffff" valign="top"> *Author:* </td> <td bgcolor="#ffffff" valign="top">Kevin Jennings</td> </tr> <tr> <td bgcolor="#edf4f9" valign="top"> *Email:* </td> <td bgcolor="#edf4f9" valign="top"><a href="http://www.eda-twiki.org/cgi-bin/view.cgi/Main/KevinJennings" target="_top">KevinJennings</a></td> </tr> <tr> <td bgcolor="#ffffff" valign="top"> *Source Doc:* </td> <td bgcolor="#ffffff" valign="top"> [[RepairExample563][Repair example in Section 5.6.3]]</td> </tr> <tr> <td bgcolor="#edf4f9" valign="top"> *Summary:* </td> <td bgcolor="#edf4f9" valign="top">Repair example in Section 5.6.3</td> </tr> </tbody> </table>
---+++ Voting Results: Cast your votes here

Yes:
   1 %USERSIG{KevinJennings - 2016-11-30}% - ver 1
   1 %USERSIG{PatrickLehmann - 2016-12-09}% - ver 1
   1 %USERSIG{MartinThompson - 2016-12-12}% - ver 1
   1 %USERSIG{ThomasPreusser - 2016-12-15}% - ver 1
   1 %USERSIG{RyanHinton - 2016-12-19}% - ver 1
   1 %USERSIG{MartinZabel - 2017-01-19}% - ver 1
   1 %USERSIG{FarrellOstler - 2017-02-01}% - ver 1 <p> </p>
   1 %USERSIG{JimLewis - 2017-02-06}% - ver 1

No:

Abstain:
   1. %USERSIG{BrentHahoe - 2017-02-16}%  Version 1 - Abstain due to lack of personal time for review.

---++ Style Notes

<noautolink>

<sticky>
Changes are shown in %RED%red font%ENDCOLOR%.%BR%
Deletions are %RED%<del>crossed out</del>%ENDCOLOR%.%BR%
Editing or reviewing notes in %GREEN%green font%ENDCOLOR%.
 
---++ Reviewing Notes
The protected type declared in 5.6.2 declares
<pre>
procedure extract (variable r, i: out Real);
</pre>
but the procedure body in 5.6.3 misses the *variable* reserved word.


---++ Details of Language Change
---+++ LRM 5.6.3 page 60 (Adobe page 74 of 640) near middle

<pre>
<b>procedure</b> extract (%RED%variable%ENDCOLOR% r, i: out Real) <b>is</b>
</pre>


---+ Comments
I concur with Brent in the proposal.   Variable is the default.   Hence, it is not needed.   OTOH, it is still correct with it and I prefer to have the keyword there, so I only abstain.

-- %BUBBLESIG{JimLewis - 2017-02-06}%




@Jim, @Brent I added more context for this LCS. The procedure body refers to the declaration in 5.6.2, where the parameter class was explicit defined as variable. Subprogram declarations and bodies must be lexical conformant.

-- %BUBBLESIG{PatrickLehmann - 2017-02-06}%
%COMMENT%</sticky>

</noautolink>
Topic revision: r15 - 2017-04-02 - 16:32:55 - PatrickLehmann
P1076