[sv-ac] revised review of 1734

From: John Havlicek <john.havlicek_at_.....>
Date: Tue Oct 16 2007 - 04:31:33 PDT
Hi Folks:

Below is my revised review of 1734.

I thought about why I missed the missing local variable contexts.

I first noticed this problem when aligning 1549 to D4.  

By the time I got to reviewing the implementation of 1734, I had
forgotten exactly what was wrong -- I remembered that there was
something and I needed to check if the problem was in the
implementation of 1734.  

I think I missed them because they are not in the blue or red changes.
When reviewing the implementation, it is tempting to check only that
the blue text got added and the red text deleted, and that will not
catch this kind of mistake in which some of the black text gets 
perturbed or lost.

J.H.

---------------------------------------------------------------------------

* In F.3.3.1, under "Disabling of top-level properties", in the third item,
  there is a stray period:

     w^{0,i-1}\bot^\omega . \not\models P

* In F.3.6.1, under "Disabling of top-level properties", in the first and
  second items, the local variable context is missing.  Change

     - For T = P, w |/=^d T.
     - For U = Q, w |/=^d Q.

  to

     - For T = P, w,L_0 |/=^d T.
     - For U = Q, w,L_0 |/=^d Q.
    
    
  NOTE:  In the second of these, we should say "w,L_0 |/=^d U", but that 
  was a mistake in the proposal and will be fixed in 1549.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Received on Tue Oct 16 04:31:57 2007

This archive was generated by hypermail 2.1.8 : Tue Oct 16 2007 - 04:32:32 PDT