FW: [sv-ac] call to vote on 1728: vote YES with friendly amendment to preamble

I vote YES-- the LRM edits all seem fine.  However, I think we have a
slight mash-up in the preamble that should be fixed:



package pex_gen9_common_expressions;
let VALID_ARB(req, vld, arb_override) = (|(req&vld) || arb_override));
...
endpackage
module my_checker;
import pex_gen9_common_expressions::*;
logic a, b;
wire [1:0] request;
wire [1:0] valid;
reg arb_out, ovr;
...
prop: assert property(@(posedge clk)
request |-> VALID_ARB(request,valid, ovr);
...
endmodule


is roughly equivalent to the following directive:


`define at_least_two(sig, rst = 1'b0) rst || ($countones(sig) >= 2)



Those things are not roughly equivalent in any sense!   I think the
'roughly equivalent' part belongs to the *first* example.    So we
should fix this to move the 'is rougly equivalent to...' and the
following code snippet to just after these lines:
 
// in a package

let at_least_two(sig, rst = 1'b0) = rst || ($countones(sig) >= 2);

 


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.