RE: [sv-ac] Review of 1728

Hello Tom,

thank you for the review. I made the changes as you suggested. In fact,
Example 2 had another problem - the constants should not have been
substituted, since there is no evaluation yet... 
Please have a look and let me know if all is OK now. I am also uploading
it to Mantis.

Best regards,
ed
 

> -----Original Message-----
> From: owner-sv-ac@eda.org [mailto:owner-sv-ac@eda.org] On 
> Behalf Of Thomas Thatcher
> Sent: Thursday, July 26, 2007 12:40 PM
> To: sv-ac@eda-stds.org
> Subject: [sv-ac] Review of 1728
> 
> I have reviewed the proposal for 1728, and here are my comments.
> 
> Example 2, p. 4  "Declarative context binding
> This example is really convoluted.  There are two 
> declarations of variable x,
> one inside the always_comb block.  The let is defined outside 
> the always_comb
> block, so it binds to that variable, even when it is used 
> inside the block.
> But the let definition is !x, so it takes a second look to 
> see that it did in
> fact get the value of the outside x variable and inverted it. 
>  You can make
> this example easier to understand by changing the let statement
> 
> 	let y = x;
> 
> 
> Example 3, p. 4
> This example is better than example 2 at showing which values 
> of a and b are
> used in the resulting expression.  The full variable path 
> names are used to
> show how the binding occurs.  I suggest doing this in all the 
> examples.
> 
> Tom
> -- 
> ------------------
> Thomas J. Thatcher
> Sun Microsystems
> 408-616-5589
> ------------------
> 
> -- 
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
> 
> 

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.