[sv-ac] Clarification about changes in 3213

Hi all,

I made the following changes based on Shalom's comments:

Shalom

The proposal document should begin with the Mantis number and a 1-line description of it in bold font.

Dmitry

Done.

Shalom

In the new 16.5.1, the first paragraph ends, "Below is the formal definition of the sampled value.". The next paragraph begins, "The default sampled value of an expression is defined as follows:". That is, what actually follows the preceding sentence is a definition of 'default sample value', not of 'sampled value'. That is confusing.

Dmitry

Modified the sentence as:

The rest of this subclause provides the formal definition of sampling.

Shalom

"sub-expressions" should not have a hyphen.

Dmitry

Fixed.

Shalom

The following two paragraphs seem to be contradictory. The difference should be made clearer:

"- Sampled values of automatic variables (see 16.15.6), local variables (see 16.10), and active free checker variables (see 17.7.2) are their current values.

- When a past or a future value of an active free checker variable is referenced by a sampled value function (see 16.9.3 and 16.9.4), this value is sampled in the Postponed region of the corresponding past or future clock tick."

Dmitry

Added "However,"

In "When a past or a future value of an automatic variable is referenced by a sampled value function, the current value of automatic variable is taken instead," add "the" after "the current value of".

Fixed.

Shalom

In "The sampled value of such variable is the sampled value produced by the clocking block," add "a" after "such".

Dmitry

Fixed.

Shalom

In the following two paragraphs,

"- The sampled value of a constant cast expression (see 16.15.6) is defined as a current value of its argument. For example, if a is a variable, then the sampled value of const'(a) is the current value of a.

- When a past or a future value of a constant cast expression is referenced by a sampled value function, the current value of this expression is taken instead."

"constant cast" should be "const cast," where const is in bold code font. A constant cast is a cast of a constant expression (see the BNF).

Dmitry

Fixed.

Shalom

Add a xref to 6.24.1 as well as to 16.15.6.

Dmitry

Done.

Shalom

"a current value" should be "the current value".

Dmitry

Fixed

Shalom

On the following:

"The sampled value of sequence methods triggered and matched (see 16.14.6) are defined as current values returned by these methods. When a past or a future value of a sequence method is referenced by a sampled value function (see 16.9.3 and 16.9.4), this value is sampled in the Postponed region of the corresponding past or future clock tick,"

"The sampled value" at the start of the paragraph should be plural. "as current values" should be "as the current values". As before, the distinction between the cases described by the two sentences is not clear.

Dmitry

Fixed. Also added an indentation as in the previous paragraph.

Shalom

In the following paragraph,

"The sampled value of any other expression is defined recursively using values of its arguments. For example, a sampled value of an expression e1 & e2, where e1 and e2 are expressions, is the bitwise and of the sampled values of e1 and e2. In particular, if an expression contains a function application, to evaluate the sampled value of this expression, the function is applied to sampled values of its arguments at the time of the expression evaluation. For example, if a is a static module variable, s is a sequence, and f is a function, the sampled value of f(a, s.triggered) is the result of the application of f to the sampled values of a and s.triggered, i.e., to the value of a taken from the Preponed region and to the current value of s.triggered,"

"using values" should be "using the values". "a sampled value" should be "the sampled value". "bitwise and" should be "bitwise AND".

Dmitry

Fixed.

Shalom

The LRM does not use the term "apply" with respect to functions.

Dmitry

Rephrased as:

"In particular, if an expression contains a function call, to evaluate the sampled value of this expression, the function is called on the sampled values of its arguments at the time of the expression evaluation."

Shalom

Before the next change, "REPLACE", it would be good to add a note that it is also referring to 16.5, as two pages have passed since the previous reference.

Dmitry

Done.

Shalom

This change adds a heading "16.5.3 Assertion clock". The previous change adds 16.5.1. However, there is no 16.5.2.

Dmitry

Fixed.

Shalom

Before the next change, "REPLACE", it would be good to add a note that it is also referring to 16.5, as the addition of the 16.5.3 header in the previous change could make the location of the text of this change unclear.

Dmitry

Done.

Shalom

This proposal deletes subclause 16.6.2. So the following also have to change:

In 16.6, "There are certain restrictions on the expressions that can appear in concurrent assertions. The restrictions on operand types, variables, and operators are specified in 16.6.1, 16.6.2, and 16.6.3."

In 16.6.1, " - class, static class members are allowed (see 16.6.2)". See 0002353<http://www.eda-stds.org/mantis/view.php?id=2353>.

Dmitry

Updated 16.6 and added a note to the editor regarding 2353.

Shalom

In 16.9.3, if the intent is for "The following functions are provided:" to begin a new paragraph (which I think is good), then an explicit note to the editor should be added. Otherwise, it may not be noticed.

Dmitry

Done

Shalom

In 16.9.3, "The function $sampled is useful to access the value of expressions used in concurrent assertions in their action block," "action block" should be plural.

Dmitry

Fixed.

Thanks,
Dmitry
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.